]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: Fix sk_psock refcnt leak when receiving message
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Sun, 26 Apr 2020 03:35:15 +0000 (11:35 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 27 Apr 2020 21:04:05 +0000 (23:04 +0200)
commitda4b4f93b63640b9f57d4232272923153bcf24bb
tree2469e6fd5815c9d482d05637742e15ce603b3e86
parent3a23319495e7b363241c297eadabdfb06b8de4f7
bpf: Fix sk_psock refcnt leak when receiving message

tcp_bpf_recvmsg() invokes sk_psock_get(), which returns a reference of
the specified sk_psock object to "psock" with increased refcnt.

When tcp_bpf_recvmsg() returns, local variable "psock" becomes invalid,
so the refcount should be decreased to keep refcount balanced.

The reference counting issue happens in several exception handling paths
of tcp_bpf_recvmsg(). When those error scenarios occur such as "flags"
includes MSG_ERRQUEUE, the function forgets to decrease the refcnt
increased by sk_psock_get(), causing a refcnt leak.

Fix this issue by calling sk_psock_put() or pulling up the error queue
read handling when those error scenarios occur.

Fixes: 6e749499d9f1f ("bpf/sockmap: Read psock ingress_msg before sk_receive_queue")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/1587872115-42805-1-git-send-email-xiyuyang19@fudan.edu.cn
net/ipv4/tcp_bpf.c