]> git.baikalelectronics.ru Git - kernel.git/commit
stmmac: socfpga: remove extra call to socfpga_dwmac_setup
authorDinh Nguyen <dinguyen@opensource.altera.com>
Fri, 15 Apr 2016 01:42:29 +0000 (20:42 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 17 Apr 2016 01:46:56 +0000 (21:46 -0400)
commitd95aef6888d34221ff6b1e7814e6ae241b950076
tree19cce661e0e826eab103e677f84a6c651b5ea8f6
parentcbcec6f3df3b33a6caa0da586d386f6015ee48a3
stmmac: socfpga: remove extra call to socfpga_dwmac_setup

In the socfpga_dwmac_probe function, we have a call to socfpga_dwmac_setup,
which is already called from socfpga_dwmac_init later in the probe function.
Remove this extra call to socfpga_dwmac_setup.

Also we should not be calling socfpga_dwmac_setup() directly without wrapping
it around the proper reset assert/deasserts. That is because the
socfpga_dwmac_setup() is setting up PHY modes in the system manager, and it
is requires the EMAC's to be in reset during the PHY setup.

Reported-by: Matthew Gerlach <mgerlach@opensource.altera.com>
Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c