]> git.baikalelectronics.ru Git - kernel.git/commit
ipv6: protect mtu calculation of wrap-around and infinite loop by rounding issues
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Wed, 28 Oct 2015 12:21:04 +0000 (13:21 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Oct 2015 14:01:50 +0000 (07:01 -0700)
commitd94cc952e3036bc1e5b1778207831f4065f7ea68
tree90181c41b4521baaac793ad38f57c51d3957a663
parent26f1b50bbe4cb0cdf6452bc5c33dcb17dbd440e7
ipv6: protect mtu calculation of wrap-around and infinite loop by rounding issues

Raw sockets with hdrincl enabled can insert ipv6 extension headers
right into the data stream. In case we need to fragment those packets,
we reparse the options header to find the place where we can insert
the fragment header. If the extension headers exceed the link's MTU we
actually cannot make progress in such a case.

Instead of ending up in broken arithmetic or rounding towards 0 and
entering an endless loop in ip6_fragment, just prevent those cases by
aborting early and signal -EMSGSIZE to user space.

This is the second version of the patch which doesn't use the
overflow_usub function, which got reverted for now.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_output.c