]> git.baikalelectronics.ru Git - kernel.git/commit
devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings
authorMike Looijmans <mike.looijmans@topic.nl>
Wed, 5 Oct 2016 14:03:08 +0000 (16:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Oct 2016 00:49:12 +0000 (20:49 -0400)
commitd93a25b9c336dbfb625774563379168c1fdea66a
treed0089102107d0070571f0e154357e7d8a43da07d
parentcdad426d20df69b55254c6a784de1e1b7c3e1761
devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings

The KSZ9031 skew registers contain an offset, the chip's default value
is "neutral" which does not add any skew. Programming a 0 into a skew
property will actually set it the maximal negative adjustment and not
to a neutral position as one would expect.

Explain this situation in the devicetree binding documentation and list
the settings that the chip considers neutral.

Changing the implementation to accept negative values would have been
a better solution, but would break existing configurations.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/devicetree/bindings/net/micrel-ksz90x1.txt