]> git.baikalelectronics.ru Git - kernel.git/commit
nfs: remove incorrect fallthrough label
authorNick Desaulniers <ndesaulniers@google.com>
Thu, 17 Sep 2020 21:45:45 +0000 (14:45 -0700)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Fri, 2 Oct 2020 12:43:08 +0000 (08:43 -0400)
commitd93234f0ae6272ef6b217e0739027575e278222d
treec0e7ac1b4ff75c50462bea84ce3f5bc0020d06f7
parentec237caec7bdcfcee336df8f731bc06cf38ced6d
nfs: remove incorrect fallthrough label

There is no case after the default from which to fallthrough to. Clang
will error in this case (unhelpfully without context, see link below)
and GCC will with -Wswitch-unreachable.

The previous commit should have just replaced the comment with a break
statement.

If we consider implicit fallthrough to be a design mistake of C, then
all case statements should be terminated with one of the following
statements:
* break
* continue
* return
* fallthrough
* goto
* (call of function with __attribute__(__noreturn__))

Fixes: 2a1390c95a69 ("nfs: Convert to use the preferred fallthrough macro")
Link: https://bugs.llvm.org/show_bug.cgi?id=47539
Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/super.c