]> git.baikalelectronics.ru Git - kernel.git/commit
mxser: don't read from UART_FCR
authorJiri Slaby <jslaby@suse.cz>
Wed, 22 Sep 2021 07:59:37 +0000 (09:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Oct 2021 12:08:09 +0000 (14:08 +0200)
commitd920d89a6201bd6c7734886f5a13e05fd6b003c9
treead92ef1a9c76d4c32c82d412d5f48a0c43a5acce
parentc1923aa3674ec970131659a2961c160b05a82edf
mxser: don't read from UART_FCR

The UART_FCR register is write-only. When reading it, one gets contents
of (read-only) UART_IIR instead as they are shared. This mistake was
performed in mxser_flush_buffer() to clear FIFOs.

Actually FCR handling throughout the driver is completely broken. On
many places, it respects neither mu860 settings, nor FIFO (16450 vs
16550) setting. This patch doesn't help to fix this, it actually does
the same. We will introduce a mxser_port::FCR in the next patch to fix
this issue.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210922075938.31390-6-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/mxser.c