]> git.baikalelectronics.ru Git - kernel.git/commit
brcmfmac: disable PCIe interrupts before bus reset
authorRafał Miłecki <rafal@milecki.pl>
Mon, 18 Nov 2019 11:53:08 +0000 (12:53 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 20 Nov 2019 07:45:35 +0000 (09:45 +0200)
commitd8b9d2bc0f9aa22ceb24062589f70b420b5d1f39
tree3c3846698b2c43f319e1cebe1754d0cf28afac1b
parentfae0f7e9320f0305083a1af5f1977d133e2cf5d0
brcmfmac: disable PCIe interrupts before bus reset

Keeping interrupts on could result in brcmfmac freeing some resources
and then IRQ handlers trying to use them. That was obviously a straight
path for crashing a kernel.

Example:
CPU0                           CPU1
----                           ----
brcmf_pcie_reset
  brcmf_pcie_bus_console_read
  brcmf_detach
    ...
    brcmf_fweh_detach
    brcmf_proto_detach
                               brcmf_pcie_isr_thread
                                 ...
                                 brcmf_proto_msgbuf_rx_trigger
                                   ...
                                   drvr->proto->pd
    brcmf_pcie_release_irq

[  363.789218] Unable to handle kernel NULL pointer dereference at virtual address 00000038
[  363.797339] pgd = c0004000
[  363.800050] [00000038] *pgd=00000000
[  363.803635] Internal error: Oops: 17 [#1] SMP ARM
(...)
[  364.029209] Backtrace:
[  364.031725] [<bf243838>] (brcmf_proto_msgbuf_rx_trigger [brcmfmac]) from [<bf2471dc>] (brcmf_pcie_isr_thread+0x228/0x274 [brcmfmac])
[  364.043662]  r7:00000001 r6:c8ca0000 r5:00010000 r4:c7b4f800

Fixes: 4ce9849f9add ("brcmfmac: reset PCIe bus on a firmware crash")
Cc: stable@vger.kernel.org # v5.2+
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c