]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: brcmstb: Do not use gc->pin2mask()
authorLinus Walleij <linus.walleij@linaro.org>
Fri, 20 Oct 2017 13:45:34 +0000 (15:45 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 25 Oct 2017 09:25:39 +0000 (11:25 +0200)
commitd87c12599851800b1c9cc855904481019614b216
treec65c4dbc651ca3f00ff6eab9053f98c9df914124
parent53f8d326c5dc3f6208737d171b14161b0d3c4b76
gpio: brcmstb: Do not use gc->pin2mask()

The pin2mask() accessor only shuffles BIT ORDER in big endian systems,
i.e. the bitstuffing is swizzled big endian so "bit 0" is bit 7 or
bit 15 or bit 31 or so.

The brcmstb only uses big endian BYTE ORDER which will be taken car of
by the ->write_reg() callback.

Just use BIT(offset) to assign the bit.

Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-brcmstb.c