]> git.baikalelectronics.ru Git - kernel.git/commit
kconfig: Clear "written" flag to avoid data loss
authorM. Vefa Bicakci <m.v.b@runbox.com>
Sat, 3 Aug 2019 10:02:12 +0000 (06:02 -0400)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Sun, 4 Aug 2019 03:44:15 +0000 (12:44 +0900)
commitd83752dd4c86410ce1585b6b025acae03f265edc
treec0325f0a0b1c7c5c60f2b7b7d07ab752f2ccde93
parent5461d267cc99bdca685c7dfe5ac957c88fd10b5d
kconfig: Clear "written" flag to avoid data loss

Prior to this commit, starting nconfig, xconfig or gconfig, and saving
the .config file more than once caused data loss, where a .config file
that contained only comments would be written to disk starting from the
second save operation.

This bug manifests itself because the SYMBOL_WRITTEN flag is never
cleared after the first call to conf_write, and subsequent calls to
conf_write then skip all of the configuration symbols due to the
SYMBOL_WRITTEN flag being set.

This commit resolves this issue by clearing the SYMBOL_WRITTEN flag
from all symbols before conf_write returns.

Fixes: 9809f0ea75a6 ("kconfig: fix missing choice values in auto.conf")
Cc: linux-stable <stable@vger.kernel.org> # 4.19+
Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kconfig/confdata.c