]> git.baikalelectronics.ru Git - kernel.git/commit
octeontx2-af: Fix undetected unmap PF error check
authorColin Ian King <colin.king@canonical.com>
Wed, 16 Dec 2020 12:36:04 +0000 (12:36 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Dec 2020 18:57:43 +0000 (10:57 -0800)
commitd7a68471af79923ac6affe54e9c3206423e2e270
tree19785113cbaff39eb3b861e89c25c5d6a051f9a7
parent07652f9aaf1817e93396c7db3efff8bd117082a1
octeontx2-af: Fix undetected unmap PF error check

Currently the check for an unmap PF error is always going to be false
because intr_val is a 32 bit int and is being bit-mask checked against
1ULL << 32.  Fix this by making intr_val a u64 to match the type at it
is copied from, namely npa_event_context->npa_af_rvu_ge.

Addresses-Coverity: ("Operands don't affect result")
Fixes: a2347c4e9bb5 ("octeontx2-af: Add devlink health reporters for NPA")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: George Cherian <george.cherian@marvell.com>
Link: https://lore.kernel.org/r/20201216123604.15369-1-colin.king@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c