]> git.baikalelectronics.ru Git - kernel.git/commit
blk-iocost: fix incorrect vtime comparison in iocg_is_idle()
authorTejun Heo <tj@kernel.org>
Tue, 10 Mar 2020 17:07:46 +0000 (13:07 -0400)
committerJens Axboe <axboe@kernel.dk>
Tue, 10 Mar 2020 17:37:00 +0000 (11:37 -0600)
commitd798b5ac4e4b720c7ba779b8bfdd9044e8ec3cbe
tree91180ac53f515b5e6e293f2828fef6bbb812b1a8
parenteb13329213052cb0e5c825200bfe335c09741855
blk-iocost: fix incorrect vtime comparison in iocg_is_idle()

vtimes may wrap and time_before/after64() should be used to determine
whether a given vtime is before or after another. iocg_is_idle() was
incorrectly using plain "<" comparison do determine whether done_vtime
is before vtime. Here, the only thing we're interested in is whether
done_vtime matches vtime which indicates that there's nothing in
flight. Let's test for inequality instead.

Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: fe734d3093a8 ("blkcg: implement blk-iocost")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-iocost.c