]> git.baikalelectronics.ru Git - kernel.git/commit
media: stm32: dcmi: Fix subdev op call with uninitialized state
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 1 Jul 2022 13:15:59 +0000 (14:15 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 15 Jul 2022 14:21:53 +0000 (15:21 +0100)
commitd789304f799774707c37f246d2c42c1015d759f3
treef85fddbc5ad188603fddaf3296868774d669bc15
parent4e5853959ca47039266b865cf4f266cd3ff5456f
media: stm32: dcmi: Fix subdev op call with uninitialized state

stm32-dcmi calls its source subdev with v4l2_subdev_call() using a
v4l2_subdev_state constructed on stack. This means that init_cfg is
never called for that state, and a source subdev that depends on the
init_cfg call may break.

A new macro has been added for this particular purpose, which properly
initializes the state, so let's use v4l2_subdev_call_state_try() here.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Tested-by: Marek Vasut <marex@denx.de>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/st/stm32/stm32-dcmi.c