]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: Intel: Skylake: fix uninitialized pointer use
authorArnd Bergmann <arnd@arndb.de>
Thu, 27 Apr 2017 10:59:58 +0000 (12:59 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 30 Apr 2017 12:46:49 +0000 (21:46 +0900)
commitd6d39b5bec389f2ec449b0239e54731c0e9c6e74
tree864eb8c1e3b1d0e0462bcd5a7d97cb58a2a40a5d
parent4afb6daabe5b8c31b200441c1f723619997abb99
ASoC: Intel: Skylake: fix uninitialized pointer use

The error handling in bxt_sst_dsp_init() got changed in a way that
it now derefences an uninitialized pointer when printing a warning
about the device not being found:

sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init':
sound/soc/intel/skylake/bxt-sst.c:567:14: error: 'skl' may be used uninitialized in this function [-Werror=maybe-uninitialized]

As we do have a valid device pointer available at the call site,
let's use that instead.

Fixes: 163925d3d6a0 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/bxt-sst.c