]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: piix4: Fix a memory leak in the EFCH MMIO support
authorJean Delvare <jdelvare@suse.de>
Wed, 22 Jun 2022 06:37:43 +0000 (08:37 +0200)
committerWolfram Sang <wsa@kernel.org>
Wed, 29 Jun 2022 19:35:44 +0000 (21:35 +0200)
commitd689d39b69921637eed2200b845330258fcd84f0
treec104a207bd63d2ec6397d398e3ffb9350515126a
parent95bff9fd66ecd812d590c69387965cb20664fd49
i2c: piix4: Fix a memory leak in the EFCH MMIO support

The recently added support for EFCH MMIO regions introduced a memory
leak in that code path. The leak is caused by the fact that
release_resource() merely removes the resource from the tree but does
not free its memory. We need to call release_mem_region() instead,
which does free the memory. As a nice side effect, this brings back
some symmetry between the legacy and MMIO paths.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
Reviewed-by: Terry Bowman <terry.bowman@amd.com>
Tested-by: Terry Bowman <Terry.Bowman@amd.com>
Fixes: 6079a8237218 ("i2c: piix4: Add EFCH MMIO support to region request and release")
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-piix4.c