]> git.baikalelectronics.ru Git - kernel.git/commit
net: qlcnic: add missed unlock in qlcnic_83xx_flash_read32
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Mon, 16 Aug 2021 13:14:04 +0000 (21:14 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 17 Aug 2021 15:27:31 +0000 (08:27 -0700)
commitd6677fb92b788a7c6c67bed2abafbd10296e4084
tree496f7ce7d00db659d2f37943be759cfb91cf4669
parent7b3a9565c85fa1c8c0727855891d6f96e9649f46
net: qlcnic: add missed unlock in qlcnic_83xx_flash_read32

qlcnic_83xx_unlock_flash() is called on all paths after we call
qlcnic_83xx_lock_flash(), except for one error path on failure
of QLCRD32(), which may cause a deadlock. This bug is suggested
by a static analysis tool, please advise.

Fixes: ccc933513b4e0 ("qlcnic: flash template based firmware reset recovery")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20210816131405.24024-1-dinghao.liu@zju.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c