]> git.baikalelectronics.ru Git - kernel.git/commit
net: bcmgenet: reapply manual settings to the PHY
authorDoug Berger <opendmb@gmail.com>
Tue, 5 Nov 2019 19:07:26 +0000 (11:07 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 Nov 2019 18:46:22 +0000 (10:46 -0800)
commitd57ca496a141720c4e9e6b33f4e65366131e9b24
treeb4ced329bbfcdbd29852a52d6ddb1072c9cd42ac
parent85b028c8d9f775c78c767ce666b411d5836e489e
net: bcmgenet: reapply manual settings to the PHY

The phy_init_hw() function may reset the PHY to a configuration
that does not match manual network settings stored in the phydev
structure. If the phy state machine is polled rather than event
driven this can create a timing hazard where the phy state machine
might alter the settings stored in the phydev structure from the
value read from the BMCR.

This commit follows invocations of phy_init_hw() by the bcmgenet
driver with invocations of the genphy_config_aneg() function to
ensure that the BMCR is written to match the settings held in the
phydev structure. This prevents the risk of manual settings being
accidentally altered.

Fixes: 83c070ed8c89 ("net: bcmgenet: add main driver file")
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c