]> git.baikalelectronics.ru Git - kernel.git/commit
batman-adv: Request iflink once in batadv_get_real_netdevice
authorSven Eckelmann <sven@narfation.org>
Sun, 27 Feb 2022 23:01:24 +0000 (00:01 +0100)
committerSimon Wunderlich <sw@simonwunderlich.de>
Wed, 2 Mar 2022 08:01:28 +0000 (09:01 +0100)
commitd573a4cbdf04a96f525f7d033f4fc6e77f2dee9b
tree7de3725a2b54c2051e9ab036a9f35921910d95a4
parentfac0fb6e7c3c001a20289b4955d9ef83c38ae051
batman-adv: Request iflink once in batadv_get_real_netdevice

There is no need to call dev_get_iflink multiple times for the same
net_device in batadv_get_real_netdevice. And since some of the
ndo_get_iflink callbacks are dynamic (for example via RCUs like in
vxcan_get_iflink), it could easily happen that the returned values are not
stable. The pre-checks before __dev_get_by_index are then of course bogus.

Fixes: 84d89f9ffb3d ("batman-adv: additional checks for virtual interfaces on top of WiFi")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/hard-interface.c