]> git.baikalelectronics.ru Git - kernel.git/commit
dm: fix inflight IO check
authorJens Axboe <axboe@kernel.dk>
Mon, 10 Dec 2018 22:45:53 +0000 (15:45 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 11 Dec 2018 01:10:34 +0000 (18:10 -0700)
commitd570b4f79c9f989b75ae4ae6a895c8576b448b3e
tree54917292e4e39a04f4d2aba88f32bc92f4042e23
parentb55ef09cd101d9a5b24b40b97323e7461d5de608
dm: fix inflight IO check

After switching to percpu inflight counters, the inflight check
is totally buggy. It's perfectly valid for some counters to be
non-zero while having a total inflight IO count of 0, that's how
these kinds of counters work (inc on one CPU, dec on another).
Fix the md_in_flight() check to sum all counters before returning
a false positive, potentially.

While at it, remove the inflight read for IO completion. We don't
need it, just wake anyone that's waiting for the IO count to drop
to zero. The caller needs to re-check that value anyway when woken,
which it does.

Fixes: 09a756589a43 ("dm: remove the pending IO accounting")
Acked-by: Mike Snitzer <snitzer@redhat.com>
Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/dm.c