]> git.baikalelectronics.ru Git - kernel.git/commit
can: ems_usb: ems_usb_start_xmit(): fix double dev_kfree_skb() in error path
authorHangyu Hua <hbh25y@gmail.com>
Mon, 28 Feb 2022 08:36:39 +0000 (16:36 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 31 Mar 2022 07:55:27 +0000 (09:55 +0200)
commitd4f2d66d2a5c54ea116df1db6b6b69a4e4e45f84
tree9c650033daf8b280c01a88d81f7959e9b2a11908
parent226a27c3a0bbeeb4a92b3480070a0fba165b51dc
can: ems_usb: ems_usb_start_xmit(): fix double dev_kfree_skb() in error path

There is no need to call dev_kfree_skb() when usb_submit_urb() fails
beacause can_put_echo_skb() deletes the original skb and
can_free_echo_skb() deletes the cloned skb.

Link: https://lore.kernel.org/all/20220228083639.38183-1-hbh25y@gmail.com
Fixes: 07edeffafb68 ("ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface")
Cc: stable@vger.kernel.org
Cc: Sebastian Haas <haas@ems-wuensche.com>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/ems_usb.c