]> git.baikalelectronics.ru Git - kernel.git/commit
net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 8 Dec 2022 14:21:44 +0000 (22:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:14 +0000 (11:41 +0100)
commitd4e0a2af4be089fef6679a533c9461e88a813385
treead5d76b18d9bcca1086c1cc0be7ec7cc24a7586c
parentbfb8a7de0fccd72f28a3939d7bcf54a43bee4639
net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()

[ Upstream commit 4bdb1e9f63ed06df6b62cac07873f91951c95858 ]

It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.

It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.

In this case, dev_kfree_skb() is called in xemaclite_tx_timeout() to
drop the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().

Fixes: aae0199b4648 ("net: add Xilinx emac lite device driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/xilinx/xilinx_emaclite.c