]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: MIPS: Fix trace event to save PC directly
authorJames Hogan <james.hogan@imgtec.com>
Tue, 24 Feb 2015 11:46:20 +0000 (11:46 +0000)
committerMarcelo Tosatti <mtosatti@redhat.com>
Mon, 2 Mar 2015 22:17:52 +0000 (19:17 -0300)
commitd4b9e45e2b2fc093a4478db7d32371c886101e15
treee505d77449190e1c8141e8a2165d7caaf7044d17
parentddaf50615c14e1e197514b999a1f44b129326dec
KVM: MIPS: Fix trace event to save PC directly

Currently the guest exit trace event saves the VCPU pointer to the
structure, and the guest PC is retrieved by dereferencing it when the
event is printed rather than directly from the trace record. This isn't
safe as the printing may occur long afterwards, after the PC has changed
and potentially after the VCPU has been freed. Usually this results in
the same (wrong) PC being printed for multiple trace events. It also
isn't portable as userland has no way to access the VCPU data structure
when interpreting the trace record itself.

Lets save the actual PC in the structure so that the correct value is
accessible later.

Fixes: a9ab5ecdc43a ("KVM/MIPS32: MIPS arch specific APIs for KVM")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: linux-mips@linux-mips.org
Cc: kvm@vger.kernel.org
Cc: <stable@vger.kernel.org> # v3.10+
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
arch/mips/kvm/trace.h