]> git.baikalelectronics.ru Git - kernel.git/commit
can: j1939: transport: j1939_xtp_rx_dat_one(): compare own packets to detect corruptions
authorOleksij Rempel <o.rempel@pengutronix.de>
Fri, 7 Aug 2020 10:52:00 +0000 (12:52 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 14 Aug 2020 10:38:47 +0000 (12:38 +0200)
commitd46c054b4af7ad5ebc8ec84526de131ecac8028f
treee433a91b95c486e4c8b7e6c4a738e67fa8f3bd0c
parent37c0e8abc83102fd18f33f6d30659f0dd228f746
can: j1939: transport: j1939_xtp_rx_dat_one(): compare own packets to detect corruptions

Since the stack relays on receiving own packets, it was overwriting own
transmit buffer from received packets.

At least theoretically, the received echo buffer can be corrupt or
changed and the session partner can request to resend previous data. In
this case we will re-send bad data.

With this patch we will stop to overwrite own TX buffer and use it for
sanity checking.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/r/20200807105200.26441-6-o.rempel@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/transport.c