]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 64349fb) | patch
ethtool: do not set some flags, if others failed
authorJeff Garzik <jeff@garzik.org>
Fri, 26 Feb 2010 21:43:38 +0000 (21:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 28 Feb 2010 09:40:30 +0000 (01:40 -0800)
commitd453f7fef6f46adf0b669371230614bb912cec5b
treee6657e754b88ddc7074aae790510b23d93180308tree | snapshot
parent64349fbc837832a247578c2dfbf1ecee1505ceaecommit | diff
ethtool: do not set some flags, if others failed

NETIF_F_NTUPLE flag setting introduced a bug:  non-ntuple flags
like LRO may be successfully set, before ioctl(2) returns failure
to userspace.

The set-flags operation should be all-or-none, rather than leaving
things in an inconsistent state prior to reporting failure to
userspace.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c diff | blob | history
Linux Kernel Source Tree.