]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: Deduplicate interrupt disablement on PHY attach
authorLukas Wunner <lukas@wunner.de>
Wed, 27 Apr 2022 06:30:51 +0000 (08:30 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 29 Apr 2022 01:37:48 +0000 (18:37 -0700)
commitd3da80f4daac7445c514fbe4b272612ba399995a
tree5d4e0f4508a27947e2cd257a117073d1f205cb75
parent89b10cf844fb350c0e2977fd9f6cb3aadc6df4c0
net: phy: Deduplicate interrupt disablement on PHY attach

phy_attach_direct() first calls phy_init_hw() (which restores interrupt
settings through ->config_intr()), then calls phy_disable_interrupts().

So if phydev->interrupts was previously set to 1, interrupts are briefly
enabled, then disabled, which seems nonsensical.

If it was previously set to 0, interrupts are disabled twice, which is
equally nonsensical.

Deduplicate interrupt disablement.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/805ccdc606bd8898d59931bd4c7c68537ed6e550.1651040826.git.lukas@wunner.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy_device.c