]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: qla2xxx: Move debug messages before sending srb preventing panic
authorBill Kuzeja <William.Kuzeja@stratus.com>
Thu, 14 Feb 2019 15:52:29 +0000 (10:52 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Feb 2019 23:58:34 +0000 (18:58 -0500)
commitd3d953d7b84178d72c185efe0b22434f5303a1a9
tree89fdfcb2897b769c63210b462cb617d25621d4ff
parent8654c3eb809db2931855bbcd1213c0f0cfe7d004
scsi: qla2xxx: Move debug messages before sending srb preventing panic

When sending an srb with qla2x00_start_sp, the sp can complete and be freed
by the time we log the debug message saying we sent it. This can cause a
panic if sp gets reused quickly or when running a kernel that poisons freed
memory.

This was partially fixed by (not every case was addressed):

Commit 26e22bd2be0d ("scsi: qla2xxx: Move log messages before issuing
command to firmware")

Signed-off-by: Bill Kuzeja <william.kuzeja@stratus.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_gs.c
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_target.c