]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5: Add command entry handling completion
authorMoshe Shemesh <moshe@mellanox.com>
Fri, 27 Dec 2019 05:01:53 +0000 (07:01 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Sat, 23 May 2020 00:28:34 +0000 (17:28 -0700)
commitd3b84c9a6e12eb1c62aa694022994f35f6b4b4d9
tree6df648de812dc786f0e89dffe5c4c86198e31fae
parentb660aeeb34b5eb5c98e29e2df1185e5a565494fc
net/mlx5: Add command entry handling completion

When FW response to commands is very slow and all command entries in
use are waiting for completion we can have a race where commands can get
timeout before they get out of the queue and handled. Timeout
completion on uninitialized command will cause releasing command's
buffers before accessing it for initialization and then we will get NULL
pointer exception while trying access it. It may also cause releasing
buffers of another command since we may have timeout completion before
even allocating entry index for this command.
Add entry handling completion to avoid this race.

Fixes: 7c120481afcc ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/cmd.c
include/linux/mlx5/driver.h