]> git.baikalelectronics.ru Git - kernel.git/commit
md/raid5: fix another livelock caused by non-aligned writes.
authorNeilBrown <neilb@suse.de>
Sun, 1 Feb 2015 23:44:29 +0000 (10:44 +1100)
committerNeilBrown <neilb@suse.de>
Mon, 2 Feb 2015 05:57:17 +0000 (16:57 +1100)
commitd3b1cc47917d94cd6930f2e7164dc9dfd5af4a46
tree62450049509e3f8413f2e3dbe52bd1f29d747e7f
parentd6f6838a954ef997f3adbe88d9d1fa5c2573a311
md/raid5: fix another livelock caused by non-aligned writes.

If a non-page-aligned write is destined for a device which
is missing/faulty, we can deadlock.

As the target device is missing, a read-modify-write cycle
is not possible.
As the write is not for a full-page, a recontruct-write cycle
is not possible.

This should be handled by logic in fetch_block() which notices
there is a non-R5_OVERWRITE write to a missing device, and so
loads all blocks.

However since commit cb5601e4bf0926, that code requires
STRIPE_PREREAD_ACTIVE before it will active, and those circumstances
never set STRIPE_PREREAD_ACTIVE.

So: in handle_stripe_dirtying, if neither rmw or rcw was possible,
set STRIPE_DELAYED, which will cause STRIPE_PREREAD_ACTIVE be set
after a suitable delay.

Fixes: cb5601e4bf092664820f84146bf4c5b624316934
Cc: stable@vger.kernel.org (v3.16+)
Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Tested-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c