]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout
authorColin Ian King <colin.king@canonical.com>
Tue, 8 Aug 2017 09:52:32 +0000 (10:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Aug 2017 04:07:41 +0000 (21:07 -0700)
commitd340210a88a087e7494cea955c3b53b6f89f0729
tree6bf316536e4f3653559f89c81c040028a0748cba
parent8b38926ae7e7ba4ec1ea29eca1ceefd499537859
net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout

Change post-decrement compare to pre-decrement to avoid an
unsigned integer wrap-around on timeout. This leads to the following
!timeout check to never to be true so -ETIMEDOUT is never returned.

Detected by CoverityScan, CID#1452623 ("Logically dead code")

Fixes: eb09d740da76 ("net: phy: mdio-bcm-unimac: factor busy polling loop")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/mdio-bcm-unimac.c