]> git.baikalelectronics.ru Git - kernel.git/commit
clk: bcm2835: Make peripheral PLLC critical
authorMaxime Ripard <maxime@cerno.tech>
Mon, 26 Sep 2022 08:45:09 +0000 (10:45 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 11:22:59 +0000 (13:22 +0200)
commitd321c02568e79a1b9e4bc156cefd4e94746bc486
tree2bc8a484ea11ed2fd6a460cb898302c42bcba447
parent12368d46ab1499f1d985e0e0a4862a248949f04f
clk: bcm2835: Make peripheral PLLC critical

[ Upstream commit ee487b9c7ae6aea8f2e37b91d640e6ce472d5123 ]

When testing for a series affecting the VEC, it was discovered that
turning off and on the VEC clock is crashing the system.

It turns out that, when disabling the VEC clock, it's the only child of
the PLLC-per clock which will also get disabled. The source of the crash
is PLLC-per being disabled.

It's likely that some other device might not take a clock reference that
it actually needs, but it's unclear which at this point. Let's make
PLLC-per critical so that we don't have that crash.

Reported-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/bcm/clk-bcm2835.c