]> git.baikalelectronics.ru Git - uboot.git/commit
watchdog: use time_after_eq() in watchdog_reset()
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Tue, 13 Apr 2021 14:43:20 +0000 (16:43 +0200)
committerStefan Roese <sr@denx.de>
Tue, 27 Apr 2021 06:28:07 +0000 (08:28 +0200)
commitd2cf8324a0335fa88aab4e37d9c50fff8e998b1c
treeb209c696f0b590a8d7e447e0c15110b888f629cc
parentf7ed39dc0659383bc738996e23f69f7135c62aa6
watchdog: use time_after_eq() in watchdog_reset()

Some boards don't work with the rate-limiting done in the generic
watchdog_reset() provided by wdt-uclass.

For example, on powerpc, get_timer() ceases working during bootm since
interrupts are disabled before the kernel image gets decompressed, and
when the decompression takes longer than the watchdog device
allows (or enough of the budget that the kernel doesn't get far enough
to assume responsibility for petting the watchdog), the result is a
non-booting board.

As a somewhat hacky workaround (because DT is supposed to describe
hardware), allow specifying hw_margin_ms=0 in device tree to
effectively disable the ratelimiting and actually ping the watchdog
every time watchdog_reset() is called. For that to work, the "has
enough time passed" check just needs to be tweaked a little to allow
the now==next_reset case as well.

Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Stefan Roese <sr@denx.de>
drivers/watchdog/wdt-uclass.c