]> git.baikalelectronics.ru Git - kernel.git/commit
iwl3945/iwlwifi: fix led bug when SW rfkill
authorAbhijeet Kolekar <abhijeet.kolekar@intel.com>
Wed, 3 Jun 2009 18:44:09 +0000 (11:44 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 4 Jun 2009 14:58:10 +0000 (10:58 -0400)
commitd26bf477f47db16ee7d8295aa4a6d4e984e4cdeb
treef563037a291cdfbff684cf63b14dd0d3618c8f16
parent3d8e8e24ce88ad887165dc82b8956630d75b59d8
iwl3945/iwlwifi: fix led bug when SW rfkill

Patch fixes the bug at
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1903

when SW rfkill is invoked by 'iwconfig txpower off',
the existing connection disassociates and led off command is sent
to the device which returns error as rfkill is 'true'.

Patch fixes this by just avoiding sending the led off/on command when
disassociated. The main purpose of the led_disassociate callback
is to start or stop the blinking.
There are three states in led
1) Always on when radio is on
2) Always off when radio is off
3) blink when associated and if there is some traffic.

In this callback 'allow_blinking' needs to be set false
when associated, as LED will be always on.

Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-3945-led.c
drivers/net/wireless/iwlwifi/iwl-led.c