]> git.baikalelectronics.ru Git - kernel.git/commit
spi: synquacer: Fix timeout handling in synquacer_spi_transfer_one()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 15 Feb 2023 13:01:28 +0000 (14:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:33:23 +0000 (09:33 +0100)
commitd2496a2ab68dd2e791339e4762dd0ba6dd2664af
tree3851bdda252c1dcdbcf80fea1b3cdc97585a570a
parent529a2a19e73fffcbb4edd7e940dc05714dd55322
spi: synquacer: Fix timeout handling in synquacer_spi_transfer_one()

[ Upstream commit 4f1a413d3e4bee17704ad1b3f4997c426bf81599 ]

wait_for_completion_timeout() never returns a <0 value. It returns either
on timeout or a positive value (at least 1, or number of jiffies left
till timeout)

So, fix the error handling path and return -ETIMEDOUT should a timeout
occur.

Fixes: 55922e05ef32 ("spi: Add spi driver for Socionext SynQuacer platform")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Link: https://lore.kernel.org/r/c2040bf3cfa201fd8890cfab14fa5a701ffeca14.1676466072.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-synquacer.c