]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: Cosmetic changes to neighbor discovery logic
authorAllan Stephens <Allan.Stephens@windriver.com>
Mon, 28 Feb 2011 15:03:05 +0000 (10:03 -0500)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 13 Mar 2011 20:35:18 +0000 (16:35 -0400)
commitd23567f4149679034673f3537847910ddd3daf78
tree4ba4e220b32bd45202a3cf160c52b1b71ecb23f2
parentf753ee25a6e40f6d0de0176845a9d1b963f06f87
tipc: Cosmetic changes to neighbor discovery logic

Reworks the appearance of the routine that processes incoming
LINK_CONFIG messages to keep the main logic flow at a consistent level
of indentation, and to add comments outlining the various phases involved
in processing each message. This rework is being done to allow upcoming
enhancements to this routine to be integrated more cleanly.

The diff isn't really readable, so know that it was a case of the
old code being like:

tipc_disc_recv_msg(..)
{
if (in_own_cluster(orig)) {
...
lines and lines of stuff
...
}
}

which is now replaced with the more sane:

tipc_disc_recv_msg(..)
{
if (!in_own_cluster(orig))
return;
...
lines and lines of stuff
...
}

Instances of spin locking within the reindented block were replaced with
the identical tipc_node_[un]lock() abstractions.  Note that all these
changes are cosmetic in nature, and do not change the way LINK_CONFIG
messages are processed.

Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/tipc/discover.c