]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: remove CMD_WANT_SKB flag if send_cmd_sync failure
authorZhu Yi <yi.zhu@intel.com>
Thu, 8 Jan 2009 18:19:58 +0000 (10:19 -0800)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 16 Jan 2009 22:08:23 +0000 (17:08 -0500)
commitd1d13bc56dd97b57ac59b04af90cb24a486fe530
tree825a40a62522c5571f0c617bae95c4230dc60b6b
parente15c7c94b3af901e620a4ff89c94ea65ce375cbf
iwlwifi: remove CMD_WANT_SKB flag if send_cmd_sync failure

In function iwl_send_cmd_sync(), if the flag CMD_WANT_SKB is set but
we are not provided with a valid SKB (cmd->meta.u.skb == NULL), we need
to remove the CMD_WANT_SKB flag from the TX cmd queue. Otherwise in case
the cmd comes in later, it will possibly set an invalid address. Thus
it causes an invalid memory access.

This fixed the bug http://bugzilla.kernel.org/show_bug.cgi?id=11326.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-hcmd.c
drivers/net/wireless/iwlwifi/iwl3945-base.c