]> git.baikalelectronics.ru Git - kernel.git/commit
ubifs: dirty_cow_znode: Fix memleak in error handling path
authorZhihao Cheng <chengzhihao1@huawei.com>
Fri, 18 Nov 2022 09:02:36 +0000 (17:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:55:21 +0000 (13:55 +0100)
commitd176afdb917f9dd457f37f90ad268d0868aee422
treea0e0bc2a6f05965d38b70f2a603c01c2e895004a
parent385588ff0b4dd5d0c0fbc24a44ffe603266bb602
ubifs: dirty_cow_znode: Fix memleak in error handling path

[ Upstream commit 6dfb72935bc13abbc71fd3a295616eb9bab76e86 ]

Following process will cause a memleak for copied up znode:

dirty_cow_znode
  zn = copy_znode(c, znode);
  err = insert_old_idx(c, zbr->lnum, zbr->offs);
  if (unlikely(err))
     return ERR_PTR(err);   // No one refers to zn.

Fix it by adding copied znode back to tnc, then it will be freed
by ubifs_destroy_tnc_subtree() while closing tnc.

Fetch a reproducer in [Link].

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216705
Fixes: 974763da840d ("UBIFS: add new flash file system")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ubifs/tnc.c