]> git.baikalelectronics.ru Git - kernel.git/commit
mac80211: fix sw crypto
authorJohannes Berg <johannes@sipsolutions.net>
Mon, 25 Jan 2010 10:36:16 +0000 (11:36 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 25 Jan 2010 21:36:29 +0000 (16:36 -0500)
commitd14f85a87a62e04922b8c28c86c06a31fad90408
treedcb1b16424bf90aea7712625c2975b60c9fe9dc0
parent60f105f2949147b2edc005a838ba48f59122fefd
mac80211: fix sw crypto

What a stupid mistake. In

    commit fa96fd627a1272ab89ceb2f659160fbc4ca67332
    Author: Johannes Berg <johannes@sipsolutions.net>
    Date:   Sun Jan 17 01:47:58 2010 +0100

        mac80211: move control.hw_key assignment

I inserted code testing the wrong flags field,
which means that the test is almost always true
(it's really testing for the peer's WMM support)
and thus the later parts of the stack assume hw
crypto will be done even if that's not true.

Obviously, that broke software crypto. Maxim
said so specifically, and Jochen probably uses
some cipher that iwl3945 doesn't support in
hardware, which might also explain that Maxim
reports that even hw crypto is broken.

Fix this to test the right flags field.

Reported-by: Maxim Levitsky <maximlevitsky@gmail.com>
Reported-by: Jochen Friedrich <jochen@scram.de>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/tx.c