]> git.baikalelectronics.ru Git - kernel.git/commit
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_init
authorJosé Expósito <jose.exposito89@gmail.com>
Wed, 5 Jan 2022 17:29:12 +0000 (18:29 +0100)
committerJiri Kosina <jkosina@suse.cz>
Thu, 6 Jan 2022 14:39:43 +0000 (15:39 +0100)
commitd124229f0505e0ab64af1eacd94f784e2d5a4133
treee04263dc8d8bf8a78cafe8018384ba7684467a7d
parentf50fdc1225e5de1a654da5af049a0e92fc2407b2
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_init

The function performs a check on its input parameters, however, the
hdev parameter is used before the check.

Initialize the stack variables after checking the input parameters to
avoid a possible NULL pointer dereference.

Fixes: 87b51005c3c30 ("HID: uclogic: Extract tablet parameter discovery into a module")
Addresses-Coverity-ID: 1443831 ("Null pointer dereference")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-uclogic-params.c