]> git.baikalelectronics.ru Git - kernel.git/commit
libata-sff: use WARN instead of BUG on illegal host state machine state
authorTejun Heo <tj@kernel.org>
Fri, 29 Jan 2016 12:06:53 +0000 (07:06 -0500)
committerTejun Heo <tj@kernel.org>
Fri, 29 Jan 2016 12:06:53 +0000 (07:06 -0500)
commitd10a3c2c75aa17b64a79b28b8031dcb7a46893b0
tree6aeda131112f26a167ab509cba70354376b60ba6
parent6e39e2464f22d0d3af5ef37965eee06df1c16a0c
libata-sff: use WARN instead of BUG on illegal host state machine state

ata_sff_hsm_move() triggers BUG if it sees a host state machine state
that it dind't expect.  The risk for data corruption when the
condition occurs is low as it's highly unlikely that it would lead to
spurious completion of commands.  The BUG occasionally triggered for
subtle race conditions in the driver.  Let's downgrade it to WARN so
that it doesn't kill the machine unnecessarily.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Dmitry Vyukov <dvyukov@google.com>
drivers/ata/libata-sff.c