]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: dts: marvell: add unique identifiers for Armada A8k SPI controllers
authorMarcin Wojtas <mw@semihalf.com>
Tue, 8 Nov 2016 16:31:32 +0000 (17:31 +0100)
committerGregory CLEMENT <gregory.clement@free-electrons.com>
Wed, 9 Nov 2016 08:44:08 +0000 (09:44 +0100)
commitd101fe689d69f031a819b59adb8f508fe9859503
tree8d505155d266780d1cc2e2a78440661ba68fd390
parent015f4977fe77376601ea9798eb201a117e45eb52
arm64: dts: marvell: add unique identifiers for Armada A8k SPI controllers

Enabling SPI controllers, which are attached to different busses
inside an SoC, may result in overlapping enumeration and cause
sysfs registration failure. Example log after enabling two
controllers on Armada 8040 SoC with same identifiers:

[    3.740415] sysfs: cannot create duplicate filename
'/class/spi_master/spi0'
[    3.747510] ------------[ cut here ]------------
[    3.752145] WARNING: at fs/sysfs/dir.c:31
[...]
[    4.002299] orion_spi: probe of f4700600.spi failed with error -17

spi-orion driver offers dedicated DT property ('cell-index'), that
allow setting unique identifiers. Recently added support for CP110-slave
HW block introduced two new SPI controllers' nodes with same ID as
ones from CP110-master.

This commit fixes the issue by assigning different 'cell-index' values
for CP110-slave SPI controllers.

Fixes: 3e052de77a69 ("arm64: dts: marvell: add description for the slave
CP110 in Armada 8K")

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi