]> git.baikalelectronics.ru Git - kernel.git/commit
s390: current_stack_pointer shouldn't be a function
authorSven Schnelle <svens@linux.ibm.com>
Fri, 8 Apr 2022 12:51:26 +0000 (14:51 +0200)
committerHeiko Carstens <hca@linux.ibm.com>
Tue, 12 Apr 2022 09:56:08 +0000 (11:56 +0200)
commitd0ef91a7f953d2c131efb80e25ff4154b2b0f808
tree6196ce347eb977a4d787615260264a3255274d4d
parentb284d1f1bf36c8a8c8c6f39cd3ff6efde314eaaf
s390: current_stack_pointer shouldn't be a function

s390 defines current_stack_pointer as function while all other
architectures use 'register unsigned long asm("<stackptr reg>").

This make codes like the following from check_stack_object() fail:

if (IS_ENABLED(CONFIG_STACK_GROWSUP)) {
if ((void *)current_stack_pointer < obj + len)
return BAD_STACK;
} else {
if (obj < (void *)current_stack_pointer)
return BAD_STACK;
}

because this would compare the address of current_stack_pointer() and
not the stackpointer value.

Reported-by: Karsten Graul <kgraul@linux.ibm.com>
Fixes: 41cc6f066c42 ("usercopy: Check valid lifetime via stack depth")
Cc: Kees Cook <keescook@chromium.org>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/include/asm/entry-common.h
arch/s390/include/asm/processor.h
arch/s390/include/asm/stacktrace.h
arch/s390/lib/test_unwind.c