]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"
authorQu Wenruo <wqu@suse.com>
Tue, 12 Dec 2017 07:34:36 +0000 (15:34 +0800)
committerDavid Sterba <dsterba@suse.com>
Sat, 31 Mar 2018 00:01:05 +0000 (02:01 +0200)
commitd09179419ec00b421e9fe0b1c2f92ffc124ae4ee
treed1d4f403fcc45f10de912dbdf5faaf18802e5f07
parented0c8d2d341ada616ca8675ef1faf9b7e8c6be04
Revert "btrfs: qgroups: Retry after commit on getting EDQUOT"

This reverts commit a9f84d166f9cdcf643c10030242c0992802d2a12.

The idea to commit transaction and free some space after hitting qgroup
limit is good, although the problem is it can easily cause deadlocks.

One deadlock example is caused by trying to flush data while still
holding it:

Call Trace:
 __schedule+0x49d/0x10f0
 schedule+0xc6/0x290
 schedule_timeout+0x187/0x1c0
 wait_for_completion+0x204/0x3a0
 btrfs_wait_ordered_extents+0xa40/0xaf0 [btrfs]
 qgroup_reserve+0x913/0xa10 [btrfs]
 btrfs_qgroup_reserve_data+0x3ef/0x580 [btrfs]
 btrfs_check_data_free_space+0x96/0xd0 [btrfs]
 __btrfs_buffered_write+0x3ac/0xd40 [btrfs]
 btrfs_file_write_iter+0x62a/0xba0 [btrfs]
 __vfs_write+0x320/0x430
 vfs_write+0x107/0x270
 SyS_write+0xbf/0x150
 do_syscall_64+0x1b0/0x3d0
 entry_SYSCALL64_slow_path+0x25/0x25

Another can be caused by trying to commit one transaction while nesting
with trans handle held by ourselves:

btrfs_start_transaction()
|- btrfs_qgroup_reserve_meta_pertrans()
   |- qgroup_reserve()
      |- btrfs_join_transaction()
      |- btrfs_commit_transaction()

The retry is causing more problems than exppected when limit is enabled.
At least a graceful EDQUOT is way better than deadlock.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/qgroup.c