]> git.baikalelectronics.ru Git - kernel.git/commit
kernel/printk: add kmsg SEEK_CUR handling
authorBruno Meneguele <bmeneg@redhat.com>
Tue, 17 Mar 2020 10:33:44 +0000 (07:33 -0300)
committerPetr Mladek <pmladek@suse.com>
Thu, 21 May 2020 11:32:25 +0000 (13:32 +0200)
commitd05835b81f3d023049ad97bcc4815aab84fc67d5
treeadbc01ab55fd5dd70eb61e77391fa002670490c6
parentb0218a6f4d9c21acb6abdb00b672dde69aa1626d
kernel/printk: add kmsg SEEK_CUR handling

Userspace libraries, e.g. glibc's dprintf(), perform a SEEK_CUR operation
over any file descriptor requested to make sure the current position isn't
pointing to junk due to previous manipulation of that same fd. And whenever
that fd doesn't have support for such operation, the userspace code expects
-ESPIPE to be returned.

However, when the fd in question references the /dev/kmsg interface, the
current kernel code state returns -EINVAL instead, causing an unexpected
behavior in userspace: in the case of glibc, when -ESPIPE is returned it
gets ignored and the call completes successfully, while returning -EINVAL
forces dprintf to fail without performing any action over that fd:

  if (_IO_SEEKOFF (fp, (off64_t)0, _IO_seek_cur, _IOS_INPUT|_IOS_OUTPUT) ==
  _IO_pos_BAD && errno != ESPIPE)
    return NULL;

With this patch we make sure to return the correct value when SEEK_CUR is
requested over kmsg and also add some kernel doc information to formalize
this behavior.

Link: https://lore.kernel.org/r/20200317103344.574277-1-bmeneg@redhat.com
Cc: linux-kernel@vger.kernel.org
Cc: rostedt@goodmis.org,
Cc: David.Laight@ACULAB.COM
Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Documentation/ABI/testing/dev-kmsg
kernel/printk/printk.c