]> git.baikalelectronics.ru Git - kernel.git/commit
iio: adc: ad7124: Fix potential overflow due to non sequential channel numbers
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 13 May 2021 12:07:42 +0000 (15:07 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 13 May 2021 15:32:55 +0000 (16:32 +0100)
commitd01f11e1ca09e3edea97124d61fd6c5459add2a8
tree1c620a62d1b7c94668405f42455c411b8e15480b
parent18af678ff12c307130b77ff39fa1c8da2c9cbb0e
iio: adc: ad7124: Fix potential overflow due to non sequential channel numbers

Channel numbering must start at 0 and then not have any holes, or
it is possible to overflow the available storage.  Note this bug was
introduced as part of a fix to ensure we didn't rely on the ordering
of child nodes.  So we need to support arbitrary ordering but they all
need to be there somewhere.

Note I hit this when using qemu to test the rest of this series.
Arguably this isn't the best fix, but it is probably the most minimal
option for backporting etc.

Alexandru's sign-off is here because he carried this patch in a larger
set that Jonathan then applied.

Fixes: 2c1aa08efc421 ("iio: adc: ad7124: Fix DT channel configuration")
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Cc: <Stable@vger.kernel.org>
drivers/iio/adc/ad7124.c