]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: caif: replace BUG_ON with recovery code"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:45 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:30:39 +0000 (17:30 +0200)
commitcfdea0a10150279a3df4972dd31f924f0111ad47
tree4a739ed2667dac24c1aba3346199ab4ee2a1e165
parent338a297c8d26db725c8d541e3325b5a58f23df00
Revert "net: caif: replace BUG_ON with recovery code"

This reverts commit dfc15d02eb7b5e5b3ae428ec0c94ce460585cede.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original change here was pointless as dev can never be NULL in this
function so the claim in the changelog that this "fixes" anything is
incorrect (also the developer forgot about panic_on_warn).  A follow-up
change will resolve this issue properly.

Cc: Aditya Pakki <pakki001@umn.edu>
Cc: David S. Miller <davem@davemloft.net>
Link: https://lore.kernel.org/r/20210503115736.2104747-19-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/caif/caif_serial.c