]> git.baikalelectronics.ru Git - kernel.git/commit
irqchip: armada-370-xp: Fix chained per-cpu interrupts
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Tue, 3 Mar 2015 10:27:23 +0000 (11:27 +0100)
committerJason Cooper <jason@lakedaemon.net>
Sun, 8 Mar 2015 03:58:55 +0000 (03:58 +0000)
commitcf8e1701ea94649768e988ad71af317acb4d5e70
tree572be804300f984f2143ef71ab5c0db2d40ba992
parentb7d65746744b343701de14ca433982a3229390be
irqchip: armada-370-xp: Fix chained per-cpu interrupts

On the Cortex-A9-based Armada SoCs, the MPIC is not the primary interrupt
controller. Yet, it still has to handle some per-cpu interrupt.

To do so, it is chained with the GIC using a per-cpu interrupt. However, the
current code only call irq_set_chained_handler, which is called and enable that
interrupt only on the boot CPU, which means that the parent per-CPU interrupt
is never unmasked on the secondary CPUs, preventing the per-CPU interrupt to
actually work as expected.

This was not seen until now since the only MPIC PPI users were the Marvell
timers that were not working, but not used either since the system use the ARM
TWD by default, and the ethernet controllers, that are faking there interrupts
as SPI, and don't really expect to have interrupts on the secondary cores
anyway.

Add a CPU notifier that will enable the PPI on the secondary cores when they
are brought up.

Cc: <stable@vger.kernel.org> # 3.15+
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Link: https://lkml.kernel.org/r/1425378443-28822-1-git-send-email-maxime.ripard@free-electrons.com
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
drivers/irqchip/irq-armada-370-xp.c