]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: sdhci-pci: Do not disable interrupts in sdhci_intel_set_power
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 20 Mar 2017 17:50:30 +0000 (19:50 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 23 Mar 2017 08:24:42 +0000 (09:24 +0100)
commitcf70a263bc07596d3b5ec1b100739248fff11c55
tree23354ce850fb69f150c086233d42d40bfcdc1e7f
parent2423f8242f1a936de16ab8fb19183b95cc3a9a81
mmc: sdhci-pci: Do not disable interrupts in sdhci_intel_set_power

Disabling interrupts for even a millisecond can cause problems for some
devices. That can happen when Intel host controllers wait for the present
state to propagate.

The spin lock is not necessary here. Anything that is racing with changes
to the I/O state is already broken. The mmc core already provides
synchronization via "claiming" the host.

Although the spin lock probably should be removed from the code paths that
lead to this point, such a patch would touch too much code to be suitable
for stable trees. Consequently, for this patch, just drop the spin lock
while waiting.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org # v4.9+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Ludovic Desroches <ludovic.desroches@microchip.com>
drivers/mmc/host/sdhci-pci-core.c