]> git.baikalelectronics.ru Git - kernel.git/commit
hwrng: amd - Fix PCI device refcount leak
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Fri, 2 Dec 2022 13:22:33 +0000 (21:22 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:37 +0000 (13:32 +0100)
commitcf646d592557562733ebda701b557b9288ad56c0
tree2f1bc7f25225d215178c3ffc465ef33413e50708
parent61b0584542ea3a8e9d58c33bbec264746c9ad7be
hwrng: amd - Fix PCI device refcount leak

[ Upstream commit 8fcbfdd890bb8235d928bff56635320feab15615 ]

for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.

If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() for the normal and error path.

Fixes: baf5b739fb9c ("[PATCH] Add AMD HW RNG driver")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/hw_random/amd-rng.c