]> git.baikalelectronics.ru Git - kernel.git/commit
Input: exc3000 - fix return value check of wait_for_completion_timeout
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 29 Jun 2022 05:42:35 +0000 (22:42 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 29 Jun 2022 05:45:43 +0000 (22:45 -0700)
commitcf47ac87fef5e504ca2cd4496acb0d57397558db
treea6617561744acb5fedb0d90856c248d9a669629e
parent8f38c5f81e1ad7e3f3f036907cacef7c93b290ff
Input: exc3000 - fix return value check of wait_for_completion_timeout

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 8bc7d0f5f7d4 ("Input: exc3000 - factor out vendor data request")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220411105828.22140-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/exc3000.c