]> git.baikalelectronics.ru Git - kernel.git/commit
cxgb4: fix missing unlock on ETHOFLD desc collect fail path
authorRafael Mendonca <rafaelmendsr@gmail.com>
Thu, 22 Sep 2022 17:51:08 +0000 (14:51 -0300)
committerJakub Kicinski <kuba@kernel.org>
Mon, 26 Sep 2022 20:17:53 +0000 (13:17 -0700)
commitcf194b93c39b618b5646dd3e0c255938e662bca8
tree4df3f44d53e6e48622658155e07fc2391c50fc16
parent54795c7c5a9478d5e1f96d89d6c8bb30321ac0fd
cxgb4: fix missing unlock on ETHOFLD desc collect fail path

The label passed to the QDESC_GET for the ETHOFLD TXQ, RXQ, and FLQ, is the
'out' one, which skips the 'out_unlock' label, and thus doesn't unlock the
'uld_mutex' before returning. Additionally, since commit 966459d3ee2c
("cxgb4: add EOTID tracking and software context dump"), the access to
these ETHOFLD hardware queues should be protected by the 'mqprio_mutex'
instead.

Fixes: 08836a2b9896 ("cxgb4: add ETHOFLD hardware queue support")
Fixes: 966459d3ee2c ("cxgb4: add EOTID tracking and software context dump")
Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Reviewed-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Link: https://lore.kernel.org/r/20220922175109.764898-1-rafaelmendsr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c