]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: cs42l42: Remove duplicate control for WNF filter frequency
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 3 Aug 2021 16:08:34 +0000 (17:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Aug 2021 06:56:58 +0000 (08:56 +0200)
commitcf10afb631a1fd0586a623173e362a6d6b329f9f
tree9db1932ec1e6c81794a5f8bd10b605b688a8e6e6
parent753c0d50e5cf86737d3d5c7fe203f286d04e3e4b
ASoC: cs42l42: Remove duplicate control for WNF filter frequency

[ Upstream commit 8b353bbeae20e2214c9d9d88bcb2fda4ba145d83 ]

The driver was defining two ALSA controls that both change the same
register field for the wind noise filter corner frequency. The filter
response has two corners, at different frequencies, and the duplicate
controls most likely were an attempt to be able to set the value using
either of the frequencies.

However, having two controls changing the same field can be problematic
and it is unnecessary. Both frequencies are related to each other so
setting one implies exactly what the other would be.

Removing a control affects user-side code, but there is currently no
known use of the removed control so it would be best to remove it now
before it becomes a problem.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 74178383bdae ("ASoC: Add support for CS42L42 codec")
Link: https://lore.kernel.org/r/20210803160834.9005-2-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/cs42l42.c